feat: Add support for custom username overrides#895
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@mathieu-lemay thank you for the pull request. I am a bit skeptical about it. Why add another file, another field to manage and another mapping while we already have user attributes? Can't the same outcome be achieved by adding a new |
|
@steveiliop56 Thanks for the reply, this is exactly the sort of feedback I wanted! I didn't think of using UserAttributes because I haven't used that feature in my workflow with tinyauth. I'll look into it and get back to you |
Add a new option to manually define the usernames for selected email addresses. This is mostly useful for OAuth providers that don't return
preferred_username.I'm opening this as a draft since it's a quick and dirty fix. If this is something you're interested in, I will take the time to add some validations (like email / username is not empty) and some tests.