fix(undo-redo): eviction policy to not have unbounded undo-redo stacks#2079
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryImplements LRU (Least Recently Used) eviction policy for undo-redo stacks to prevent unbounded memory growth in localStorage. Key changes:
The implementation correctly handles edge cases like existing stacks without Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Store as UndoRedoStore
participant Storage as safeStorageAdapter
participant LS as localStorage
User->>Store: push(workflowId, userId, entry)
Store->>Store: Check if stackKeys.length >= MAX_STACKS
alt Creating new stack when at limit
Store->>Store: Find oldest stack by lastUpdated
Store->>Store: Delete oldest stack
end
Store->>Store: Update/create stack with entry
Store->>Store: Set lastUpdated = Date.now()
Store->>Storage: setItem(state)
alt localStorage has space
Storage->>LS: localStorage.setItem()
else QuotaExceededError
Storage->>Storage: Log warning, continue
end
User->>Store: undo/redo operation
Store->>Store: Update lastUpdated = Date.now()
Store->>Storage: setItem(state)
Storage->>LS: localStorage.setItem()
|
This was referenced May 26, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Must evict undo-redo stacks to 5 most recent edited workflows.
Type of Change
Testing
Tested manually
Checklist