fix(triggers): disabled trigger shouldn't be added to dag

[Sg312]

Summary

Disabled triggers no longer added to the dag

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 15, 2025 8:17pm

[greptile-apps]

Greptile Overview

Greptile Summary

Prevents disabled trigger blocks from being included in workflow execution DAG, fixing an issue where disabled triggers would still execute.

• Filters out blocks with enabled === false in use-workflow-execution.ts at two key points: when building valid blocks and when filtering merged states
• Adds disabled block checking in paths.ts with fallback logic to find alternative enabled triggers if the specified trigger is disabled
• Skips disabled blocks in triggers.ts when resolving start candidates for execution
• Filters connections with disabled blocks from the adjacency map to prevent them from being reachable in the execution graph

Confidence Score: 4/5

• Safe to merge with one potential edge case to verify
• The logic is sound and consistently filters disabled blocks across the execution pipeline. However, the fallback mechanism in paths.ts could use testing to ensure it handles all edge cases properly
• Check apps/sim/executor/dag/construction/paths.ts for edge case handling when no enabled triggers are available

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts	5/5	Filters out disabled blocks in two places: when building validBlocks and when filtering mergedStates before execution
apps/sim/executor/dag/construction/paths.ts	4/5	Handles disabled trigger blocks with fallback logic and filters disabled blocks from adjacency map construction
apps/sim/lib/workflows/triggers.ts	5/5	Skips disabled blocks when resolving start candidates for workflow execution

Sequence Diagram

sequenceDiagram
    participant User
    participant ExecutionHook as useWorkflowExecution
    participant Triggers as triggers.ts
    participant PathConstructor as paths.ts
    participant Executor as Workflow Executor

    User->>ExecutionHook: Execute workflow
    ExecutionHook->>ExecutionHook: Filter blocks (enabled !== false)
    ExecutionHook->>Triggers: resolveStartCandidates()
    Note over Triggers: Skip blocks where enabled === false
    Triggers-->>ExecutionHook: Valid trigger candidates
    ExecutionHook->>PathConstructor: Build execution DAG
    PathConstructor->>PathConstructor: Check if triggerBlockId is disabled
    alt Trigger is disabled
        PathConstructor->>PathConstructor: findExplicitTrigger() for alternative
        alt Alternative found
            PathConstructor-->>ExecutionHook: Use alternative trigger
        else No alternative
            PathConstructor-->>ExecutionHook: Error: No enabled trigger
        end
    else Trigger is enabled
        PathConstructor->>PathConstructor: buildAdjacencyMap()
        Note over PathConstructor: Filter connections with disabled blocks
        PathConstructor-->>ExecutionHook: Valid execution paths
    end
    ExecutionHook->>Executor: Execute with filtered blocks
    Executor-->>User: Execution result

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}