Skip to content

[Fix #1276] Ignoring isNull for JacksonModel serialization #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Mar 30, 2026
Merged

[Fix #1276] Ignoring isNull for JacksonModel serialization #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions impl/model/src/main/java/io/serverlessworkflow/impl/model/jackson/JacksonModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package io.serverlessworkflow.impl.model.jackson;

import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
Expand Down Expand Up @@ -48,6 +49,7 @@ protected JacksonModel(JsonNode node) {
}

@Override
@JsonIgnore
public boolean isNull() {
return node.isNull();
Comment on lines 51 to 54
Copy link

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a regression test that serializing a JacksonModel with Jackson (e.g., ObjectMapper.writeValueAsString on a JacksonModel or WorkflowModel reference) does not emit a "null" field derived from isNull(). This change is intended to prevent Jackson from treating isNull as a bean property, but it’s currently untested in this module despite existing JacksonModel tests.

Copilot uses AI. Check for mistakes.
}
Expand Down
Loading