Display a different color for installed components during a toolchain install#4875
Open
FranciscoTGouveia wants to merge 1 commit into
Open
Display a different color for installed components during a toolchain install#4875FranciscoTGouveia wants to merge 1 commit into
FranciscoTGouveia wants to merge 1 commit into
Conversation
rami3l
reviewed
May 27, 2026
Member
There was a problem hiding this comment.
The :.green.bold and the actual test is too far away from each other so I'm not sure if I'd like this change... To me intuitively the prefix should have been the name of the component:
That said I'm not an indicatif expert either, but if there's a more straightforward way I'd choose that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4870.
I decided to set a prefix for the
ProgressBarsince we were not using one before.Looking at indicatif's documentation, this seemed like a reasonable way to style a specific portion of the
ProgressBar.Is there a more idiomatic approach to achieving this that I might be overlooking?
CC @djc