Skip to content

Remove duplicated hash key in chart.rb#20

Merged
trans merged 1 commit into
rubyworks:masterfrom
deepj:master
Jan 6, 2015
Merged

Remove duplicated hash key in chart.rb#20
trans merged 1 commit into
rubyworks:masterfrom
deepj:master

Conversation

@deepj
Copy link
Copy Markdown
Contributor

@deepj deepj commented Oct 28, 2014

The same hash key is on the line 29

The same hash key is on the line 29
@garysweaver
Copy link
Copy Markdown

Looks like there are several other PRs duplicating this change. Since ansi is depended on by powerbar and minitest-reporters, it would be good to have this fix quickly since Ruby 2.2 complains about duplicate keys in hashes. Thanks in advance!

@trans
Copy link
Copy Markdown
Member

trans commented Jan 6, 2015

Oh no! I haven't been getting emails for pull requests for this project. Why? 😕 Will have to figure out and fix. Thanks for emailing me directly. I'll merge this and work my way through the other PRs.

trans added a commit that referenced this pull request Jan 6, 2015
Remove duplicated hash key in chart.rb.
@trans trans merged commit 8a1f1db into rubyworks:master Jan 6, 2015
@garysweaver
Copy link
Copy Markdown

@trans, could this be released as 1.4.4 soon? Would like to get rid of:

../gems/ansi-1.4.3/lib/ansi/chart.rb:26: warning: duplicated key at line 29 ignored: :concealed

Thanks for your help!

@trans
Copy link
Copy Markdown
Member

trans commented Jan 17, 2015

Just released 1.5.0. Happy New Year!

@garysweaver
Copy link
Copy Markdown

Thanks, @trans! Happy New Year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants