[FIX] fixed a bug that abyssal web strength can go beyond -99%#2762
Closed
EVE-Rangeen wants to merge 1 commit into
Closed
[FIX] fixed a bug that abyssal web strength can go beyond -99%#2762EVE-Rangeen wants to merge 1 commit into
EVE-Rangeen wants to merge 1 commit into
Conversation
In game hard cap on web strength at -99%. Fixed pyfa to restrict this
Author
|
I made this funcation apply to all stasis webification modules/entities/AOE but actually only webs fitted on serpentis ships have the chance to reach that height. |
Member
|
Good catch, but I think fix should be different. It has to be on dogma-ish level. EVE caps it via minAttributeValue. I will fix it the proper way, closing this PR. With stronger links proper fix has more areas of application too (e.g. ewar becoming too strong is limited the same way). |
Member
|
Fixed in 01eb7e3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a single web strength cap at 99% to match eve machanics. Its not possible to get beyond -99% speed reduction in EVE
So pyfa simlulate incorrectly with god rolled strength abyssal web on serpentis ships. resulting negative speed and wrong damage graph.
Before fix
After fix
Fix
Implements a new
applyWebStrengthCapfunction incalc.pywhich cap the web strength at -99% . And apply it to wherever webifier speed reduction is calculated or displayed. Ensures any single web strength effect can not exceed -99%.Cursor has been used to help me with this fix