test: validate JMX Exporter compatibility#2167
Conversation
zeitlinger
force-pushed
the
validation/jmx-exporter-compatibility
branch
2 times, most recently
from
359cb66 to
dc50259
Compare
Signed-off-by: Gregor Zeitlinger <[email protected]>
zeitlinger
force-pushed
the
validation/jmx-exporter-compatibility
branch
from
dc50259 to
7a0431f
Compare
|
@zeitlinger are you wanting to run JMX Exporter smoke test configuration or a quick test configuration? Smoke test configuration (all integration tests, 6 Java distributions, 2 Prometheus distributions)
Quick test configuration (all integration tests, but 1 Java distribution and 1 Prometheus distribution)
|
dhoard
left a comment
dhoard
left a comment
There was a problem hiding this comment.
All in all looks good based on my understand of mise. We need to determine which level we want to run tests. smoke test configuration or quick test configuration
| - name: Run JMX Exporter compatibility tests | ||
| env: | ||
| JMX_EXPORTER_REPOSITORY: ${{ inputs.repository || 'prometheus/jmx_exporter' }} | ||
| JMX_EXPORTER_REF: ${{ inputs.ref || 'main' }} |
There was a problem hiding this comment.
for both micrometer and JMX, could we use renovate and a tag /sha instead of main? just thinking of a case where either of these projects were to be compromised, we wouldn't want to pull from main and run them
jaydeluca
left a comment
jaydeluca
left a comment
There was a problem hiding this comment.
one comment but it is non-blocking, we can do a followup
3 participants
Draft validation PR for the unmodified JMX Exporter compatibility story.
This intentionally does not depend on #2114. Vanilla JMX Exporter does not
use the typed descriptor API, so this PR validates the patch-compatible path
independently of typed descriptors.
This validates upstream
prometheus/jmx_exporter@mainagainst currentclient_javaby installing localio.prometheusartifacts and running the JMXExporter collector/common/javaagent/standalone Maven tests against them.
Local validation:
mise run jmx-exporter:testmise run lint:fixmise run lintactionlint .github/workflows/jmx-exporter-compatibility.yml