Conversation
|
atheriel
force-pushed
the
aj-login
branch
3 times, most recently
from
2b61c62 to
9c22808
Compare
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
zackverham
reviewed
May 29, 2026
zackverham
reviewed
May 29, 2026
zackverham
reviewed
May 29, 2026
zackverham
reviewed
May 29, 2026
Contributor
|
Question for my own understanding - I'm trying to follow what happens if they keyring isn't available. Is that fallback implemented in the |
zackverham
approved these changes
May 29, 2026
Contributor
Author
If it isn't available then we store the tokens in the JSON file, like we do for API keys. |
Connect version 2026.02 and later supports dynamic OAuth client registration and the authorization code flow, which is a nice way to sidestep the need for API keys. This commit wires up these flows to new `login` and `logout` subcommands. As a bonus, we store the resulting credentials in the system keyring -- when available -- for improved security. As a secondary bonus: we also support the device code flow (via `--use-device-code`) if the Connect server advertises its support for it. Indicators for the OAuth client and keyring use have also been added to the `rsconnect list` output. Unit tests are included. Closes #759. Signed-off-by: Aaron Jacobs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Connect version 2026.02 and later supports dynamic OAuth client registration and the authorization code flow, which is a nice way to sidestep the need for API keys.
This commit wires up these flows to new
loginandlogoutsubcommands. As a bonus, we store the resulting credentials in the system keyring -- when available -- for improved security.As a secondary bonus: we also support the device code flow (via
--use-device-code) if the Connect server advertises its support for it.Indicators for the OAuth client and keyring use have also been added to the
rsconnect listoutput.Resolves #759.
Type of Change
Automated Tests
Unit tests are included.
Directions for Reviewers
You can test that it works against any recent Connect server:
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.