latest: pin kolla_ansible docker image tag#2494
Open
ideaship wants to merge 1 commit into
Open
Conversation
7 tasks
latest/base.yml had no docker_images.kolla_ansible entry. This caused
generics/environments/manager/images.yml to fall into its
{% if manager_version == 'latest' %} branch, which resolved
kolla_ansible_tag to openstack_version (e.g. 2025.1) at render time.
The kolla/release/2025.1/ registry namespace carries only date-stamped
tags such as 5.0.9.20260328. The floating 2025.1 tag exists only in the
bare kolla/ namespace, not in kolla/release/2025.1/. Any upgrade run
using the rendered tag therefore receives a 500 from the registry when
pulling per-service images (e.g. fluentd), failing the Restart handler
on all targeted hosts.
Add kolla_ansible: '0.20260328.0' to docker_images, matching the value
in the current stable release (10.0.0/base.yml). With this entry
present, the generics template's {% if 'kolla_ansible' in versions %}
path fires for latest and uses the pinned, date-stamped tag rather than
the rolling openstack_version fallback.
Add a datasource=docker Renovate annotation so future stable kolla-
ansible tags are tracked automatically. Add an allowedVersions package
rule restricting proposals to the 0.YYYYMMDD.N format, preventing
Renovate from ever proposing rolling OpenStack tags (2025.1, master).
This is the release-side half of a two-repo fix. The generics side
removes the {% if manager_version == 'latest' %} bypass for
kolla_ansible_tag once this entry is present and merged.
AI-assisted: Claude Code
Signed-off-by: Roger Luethi <[email protected]>
ideaship
force-pushed
the
fix/pin-kolla-ansible-in-latest
branch
from
9baa0b4 to
c79a495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker_images.kolla_ansible: '0.20260328.0'tolatest/base.ymlwith adatasource=dockerRenovate annotationallowedVersionspackage rule to.github/renovate.jsonrestricting Renovate to stable date-based tags (0.YYYYMMDD.N), preventing proposals of rolling OpenStack tags like2025.1This is the release-side half of a two-repo fix for
kolla/release/2025.1/fluentd:2025.1 not found500 errors intestbed-upgrade-stable-next-ubuntu-24.04. Without this entry,generics/environments/manager/images.ymlfell into amanager_version == 'latest'bypass that resolvedkolla_ansible_tagtoopenstack_versionrather than the pinned date-stamped tag.Must be merged before osism/generics#595.
Test plan
python3 -c "import yaml; yaml.safe_load(open('latest/base.yml'))"passespython3 -c "import json; json.load(open('.github/renovate.json'))"passesMANAGER_VERSION=latest tox -e testin generics produceskolla_ansible_tag: 0.20260328.0