Skip to content

Add unit tests for osism/utils task output and helpers #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
berendt wants to merge 2 commits into
base: main
Choose a base branch
from
+702 −2
Open

Add unit tests for osism/utils task output and helpers #2298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf647be
Add unit tests for osism/utils task output and helpers
berendt May 20, 2026
ef68c52
Fix env-var timeout cast, timeout connection leak, and rc=0 drop in t…
berendt May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions osism/utils/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,9 @@ def first(iterable, condition=lambda x: True):


def fetch_task_output(
task_id, timeout=os.environ.get("OSISM_TASK_TIMEOUT", 300), enable_play_recap=False
task_id,
timeout=int(os.environ.get("OSISM_TASK_TIMEOUT", 300)),
enable_play_recap=False,
):
r = _init_redis()
rc = 0
Expand Down Expand Up @@ -401,6 +403,7 @@ def fetch_task_output(
elif message_type == "action" and message_content == "quit":
r.close()
return rc
r.close()
raise TimeoutError


Expand All @@ -410,7 +413,7 @@ def push_task_output(task_id, line):

def finish_task_output(task_id, rc=None):
r = _init_redis()
if rc:
if rc is not None:
r.xadd(task_id, {"type": "rc", "content": rc})
r.xadd(task_id, {"type": "action", "content": "quit"})

Expand Down
Loading