Skip to content

[FSSDK-9076] fix: send odp event empty values#513

Merged
mnoman09 merged 3 commits into
masterfrom
mnoman/FSSDK-9076
Apr 25, 2023
Merged

[FSSDK-9076] fix: send odp event empty values#513
mnoman09 merged 3 commits into
masterfrom
mnoman/FSSDK-9076

Conversation

@mnoman09
Copy link
Copy Markdown
Contributor

Summary

  • Validate sendOdpEvent empty action and type parameters
  • Generate new idempotence_id for every OdpEvent

Test plan

added tests and all tests should pass.

Ticket

FSSDK-9076

Copy link
Copy Markdown
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	core-api/src/main/java/com/optimizely/ab/odp/ODPEventManager.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants