Convert agenda item into work package#23339
Conversation
oliverguenther
force-pushed
the
feat/turn-agenda-into-wp
branch
from
79a9982 to
1d43678
Compare
HDinger
left a comment
HDinger
left a comment
There was a problem hiding this comment.
Looks good overall.
There is one issue I found when the item already has an outcome: the outcome is taken into the description of the WP, leading to effectivly duplicating the outcome:
| with_item_group(menu) do | ||
| add_note_action_item(menu) if add_note_action? | ||
| add_outcome_action_items(menu) if add_outcome_action? | ||
| convert_to_work_package_action_item(menu) if convert_to_work_package_action? |
There was a problem hiding this comment.
In Figma, the option is below "Copy link to clipboard" not below "add outcome".
| ), | ||
| method: "GET" | ||
| } }) do |item| | ||
| item.with_leading_visual_icon(icon: :"package-dependents") |
There was a problem hiding this comment.
The ticket says package-dependents whereas in Figma op-work-packages is used. Don't know which is supposed to be correct.
There was a problem hiding this comment.
package-dependents is correct as is
Yes that's true, we could skip outputting the outcomes to the descriptions altogether. I'm not sure what path we should take here. It is implemented as specified, and I'm not sure if it's a big deal to duplicate that |
oliverguenther
force-pushed
the
feat/turn-agenda-into-wp
branch
2 times, most recently
from
c6da733 to
03ba623
Compare
oliverguenther
force-pushed
the
feat/turn-agenda-into-wp
branch
from
03ba623 to
981e2dc
Compare
2 participants
https://community.openproject.org/work_packages/57053