fix(devtools-kit): pass cwd to execa#960
Conversation
Deploying nuxt-devtools with
|
| Latest commit: |
bf3acde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa4ef608.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://fix-startsubprocess-cwd.nuxt-devtools.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/devtools-kit/src/index.ts`:
- Around line 51-54: The nodeOptions object assignment currently overwrites any
existing execaOptions.nodeOptions.cwd with execaOptions.cwd even when
execaOptions.cwd is undefined; change the cwd assignment in the nodeOptions
block so it uses execaOptions.cwd only when it is defined and otherwise
preserves execaOptions.nodeOptions.cwd (i.e., use a nullish-coalescing style
fallback for cwd), leaving the rest of the nodeOptions spread untouched (refer
to the nodeOptions object in packages/devtools-kit/src/index.ts).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 342a7d6c-3e35-4337-8919-b839d6772776
📒 Files selected for processing (1)
packages/devtools-kit/src/index.ts
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
🔗 Linked issue
📚 Description
Ran into some issues when starting devtools in local mode.
Seems like execa gets cwd from nodeOptions now