stream: handle falsy push writer fail reasons#63569
Open
trivikr wants to merge 1 commit into
Open
Conversation
Reject reads based on writer state so explicit falsy fail reasons do not leave reads pending. Fixes: nodejs#63568 Signed-off-by: Kamat, Trivikram <[email protected]> Assisted-by: openai:gpt-5.5
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63569 +/- ##
=======================================
Coverage 90.34% 90.34%
=======================================
Files 730 730
Lines 234463 234468 +5
Branches 43914 43918 +4
=======================================
+ Hits 211816 211834 +18
- Misses 14367 14370 +3
+ Partials 8280 8264 -16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes
stream/iterpush writer reads afterwriter.fail()is calledwith an explicit falsy reason.
Reads now use the writer state instead of the truthiness of the stored error,
so reasons like
0andfalsereject correctly instead of leaving readspending.
Fixes: #63568
Assisted-by: openai:gpt-5.5