Skip to content

test_runner: add cwd option to run#54705

Merged
nodejs-github-bot merged 20 commits into
nodejs:mainfrom
pmarchini:feat/cwd-option-run
Oct 3, 2024
Merged

test_runner: add cwd option to run#54705
nodejs-github-bot merged 20 commits into
nodejs:mainfrom
pmarchini:feat/cwd-option-run

Conversation

@pmarchini
Copy link
Copy Markdown
Member

I'm opening this PR as a draft to have a place where we can discuss this implementation.

Some background context:

During #54225, we discussed the possibility of adding a new option to run.
This new option would be cwd.

This change could impact many other parts of the code, such as:
#54225 (comment)

I just pushed a new commit.

Nice. I realized that this new cwd option may introduce new bugs in at least three places:

For this reason, we decided to work on this in a separate PR (#54225 (comment)).

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants