lib: fix off-by-one indentation#14064
Closed
Trott wants to merge 1 commit into
Closed
Conversation
In preparation for more robust indentation linting, fix an off-by-one indentation in lib/http_server.js.
tniessen
approved these changes
Jul 3, 2017
addaleax
approved these changes
Jul 3, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Doesn’t need to wait 48 hours
vsemozhetbyt
approved these changes
Jul 3, 2017
cjihrig
approved these changes
Jul 3, 2017
fhinkel
approved these changes
Jul 3, 2017
Member
Author
targos
approved these changes
Jul 3, 2017
lpinca
approved these changes
Jul 4, 2017
Member
Author
|
Landed in a577bde |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 4, 2017
In preparation for more robust indentation linting, fix an off-by-one indentation in lib/http_server.js. PR-URL: nodejs#14064 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for more robust indentation linting, fix an off-by-one
indentation in lib/http_server.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
lib