-
-
Notifications
You must be signed in to change notification settings - Fork 35.7k
http perfomance regression in Node 8.10 and 8.11. #20798
Copy link
Copy link
Closed
Labels
httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Metadata
Metadata
Assignees
Labels
httpIssues or PRs related to the http subsystem.Issues or PRs related to the http subsystem.performanceIssues and PRs related to the performance of Node.js.Issues and PRs related to the performance of Node.js.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.
Type
Fields
Give feedbackNo fields configured for issues without a type.
There has been a regression on using
res.setHeader()with a CamelCase header like'Content-Type'vs'content-type'.Consider this example:
This leads us to the following benchmark:
However if we use a camel-cased header, we have:
I would note that this difference is not present in Node 8.9.4.
I've also created a few flamegraphs:
Node 8.11.1 camel cased:
Node 8.11.1 lowercase:

Node 8.9.4 camel cased:
As you can see the
setHeadermethod is not "hot" in neither 8.11.1 and 8.9.4.