Skip to content

Build break in src/tracing/agent.h #18361

@kfarnung

Description

@kfarnung
  • Version: master
  • Platform: windows, linux
  • Subsystem: tracing

It looks like #17489 and #18196 collided in master to break the build. The CurrentTimestampMicroseconds method was removed from the V8 type just as we took a dependency on it.

E:\GitHub\node\src\tracing/agent.h(15): error C3668: 'node::tracing::TracingController::CurrentTimestampMicroseconds': method with override specifier 'override' did not override any base class methods (compiling source file src\tracing\agent.cc) [E:\GitHub\node\node_lib.vcxproj]

/cc @ofrobots @targos @MylesBorins

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions