Release proposal: v1.6.3

[rvagg]

I'd really like to see some work on timers get merged, specificially #1152 (@Fishrock123) and maybe also #1231 (@silverwind). Anecdotally I'm hearing challenges with io.js adoption because of "timer bugs".

A release tomorrow is doable.

• [7dd5e824be] - assert: simplify logic of testing buffer equality (Alex Yursha) #1171
• [a2ea16838f] - debugger: don't spawn child process in remote mode (Jackson Tian) #1282
• [2752da4b64] - deps: make node-gyp work with io.js (cjihrig) #990
• [f166cdecf1] - deps: upgrade npm to 2.7.4 (Forrest L Norvell)
• [318d9d8fd7] - deps: upgrade v8 to 4.1.0.27 (Ben Noordhuis) #1289
• [269e46be37] - deps: make node-gyp work with io.js (cjihrig) #990
• [b542fb94a4] - deps: upgrade npm to 2.7.3 (Forrest L Norvell) #1219
• [73de13511d] - doc: add WG links in WORKING_GROUPS.md & fix nits (Farrin Reid) #1113
• [19641b17be] - doc: decouple sidebar scrolling (Roman Reiss) #1274
• [dbccf8d3ed] - doc: fix spelling error in feature flags (Phillip Lamplugh) #1286
• [5e609e9324] - _Revert_ "doc: clarify real name requirement" (Jeremiah Senkpiel) #1276
• [45814216ee] - doc: fix format docs discrepancy (Brendan Ashworth) #1255
• [4e9bf93e9c] - doc: clarify real name requirement (Roman Reiss) #1250
• [e84dd5f651] - doc: document repl on-demand module loading (Roman Reiss) #1249
• [c9207f7fc2] - fs: fix corruption in writeFile and writeFileSync (Olov Lassus) #1063
• [2db758c562] - iojs: introduce internal modules (Vladimir Kurchatkin) #848
• [36f017afaf] - js2c: fix module id generation on windows (Ben Noordhuis) #1281
• [1832743e18] - lib: add missing new for errors lib/*.js (Mayhem) #1246
• [ea37ac04f4] - src: ignore ENOTCONN on shutdown race with child (Ben Noordhuis) #1214
• [f06b16f2e9] - src: fix minor memleak in preload-modules (Ali Ijaz Sheikh) #1265
• [2903410aa8] - src: don't lazy-load timer globals (Ben Noordhuis) #1280
• [2e5b87a147] - src: remove unnecessary environment lookups (Ben Noordhuis) #1238
• [7e88a9322c] - src: make accessors immune to context confusion (Ben Noordhuis) #1238
• [c8fa8ccdbc] - streams: use strict on _stream_wrap (Brendan Ashworth) #1279
• [8a945814dd] - string_decoder: optimize write() (Brian White) #1209
• [8d1c87ea0a] - test: fix race in parallel/test-vm-debug-context (Ben Noordhuis) #1294
• [955c1508da] - test: reduce sequential/test-fs-watch flakiness (Roman Reiss) #1275
• [77c2da10fd] - timers: make Timer.close idempotent (Petka Antonov) #1288
• [776b73b243] - timers: cleanup interval handling (Jeremiah Senkpiel) #1272
• [caf0b36de3] - timers: assure setTimeout callback only runs once (Roman Reiss) #1231
• [2ccc8f3970] - tls_wrap: fix this incredibly stupid leak (Fedor Indutny) #1244
• [e74b5d278c] - tls_wrap: fix BIO leak on SSL error (Fedor Indutny) #1244
• [ba93c583bc] - win,node-gyp: optionally allow node.exe/iojs.exe to be renamed (Bert Belder) #1266
• [08acf1352c] - win,node-gyp: make delay-load hook optional (Bert Belder) #1266
• [3d46fefe0c] - win,node-gyp: allow node.exe/iojs.exe to be renamed (Bert Belder) #1251

[piscisaureus]

I'd like to get #1251 in, because the .exe naming issue causes so many issues that it forced me to actually fix it myself :). But don't hold up the release for it.

[silverwind]

I'll try to finish #1231 today, just have to make sure it causes no side effects.

[alanpurple]

I'm wating for this, thanks again 👍 :)

[Fishrock123]

#1152 will likely not be ready for this.

[silverwind]

#1231 is ready to merge from my point. Edit: It has landed.

[Fishrock123]

#1075 (comment) -- we should get this out tomorrow #1244 is making a huge difference for the leak.

[Fishrock123]

Blocked by the entire windows test suite failing due to a bug in internal modules: #848 (comment)

[rvagg]

Ouch, we should revert that unless a fix gets in within the next day or so.

/cc @vkurchatkin

[Fishrock123]

New CI post 36f017a (internal module fix): https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/

[Fishrock123]

7 specific tests have been timing out for the last several runs on win2012r2 only. Investigating.
Update: maybe just jenkins. I had an out of hdd/ram failure earlier.

https://gist.github.com/Fishrock123/be271ab4b9bbf393b23a

[Fishrock123]

#1152 is broken and should not go in. #1152 (comment)

@rvagg I think we should be mostly ok for a release if jenkins looks fine after a reboot.

Maybe just get #1285 (npm@2.7.4 in? I'll probably merge before the release if it's not in yet anyways.)

[rvagg]

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/395/ test run

[Fishrock123]

Same 6 (7 - 1) sort of timeouts we've been seeing on win2012r2 recently..