Buffered file io#63
Merged
Merged
Conversation
Replace the fgetc()-per-character loop in fgetline() with a single AmigaDOS Read() call followed by in-memory newline scan and Seek() to reposition. Reduces syscalls from ~80 per line to 2. Benchmark: 9846 lines/sec for 1000-line file on emulated 68000. Full test suite: 192/192 pass (1 pre-existing closure build failure). Co-Authored-By: Claude Opus 4.6 <[email protected]>
…getc Same Read+Seek pattern as fgetline (Step 1). fgets() keeps the newline, fgetchars() is a single Read with no seek-back. Benchmark: 12190 lines/sec (up from 9846). Full test suite: 193 pass, 0 fail. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Tested replacing fgetseqfld()'s per-char fgetc() loop with bulk Read+Seek (same pattern as Steps 1-2). INPUT# benchmark regressed 16% (4129 vs 4923 records/sec) because fields are short and AmigaDOS's internal 208-byte buffer already makes fgetc() efficient for this use case. Reverted code, kept state file documenting the finding. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.