Added the possibility for a css property (in addition to the markup property)#86
Added the possibility for a css property (in addition to the markup property)#86anchpop wants to merge 3 commits into
Conversation
|
Thanks, but I'm not entirely confident of the benefit of this feature. Can you talk a bit about your use-cases and what you're trying to solve? |
|
@markfinger Sure. I basically only added this because I wanted to get [server side rendering of MaterialUI[(https://material-ui.com/guides/server-rendering/) working and this seemed like the cleanest way. Although I think a better route forward would be to have an extra field called |
|
Yeah, a more general purpose variable for extra context might be better. So the styles are being generated in python code and you're passing them down the rendering pipeline? Is there a reason why you need to include the styles in the rendered markup, instead of using your template layer (or equivalent)? I'm still not sure of the motivating details in the implementation tbh. If you could provide some code it might help. This seems a bit use-case specific, so I'm inclined towards suggesting that you maintain your own fork. This is a tiny and stable lib, so you're not really taking on anything approaching tech debt. |
|
@markfinger |
No description provided.