Skip to content

Add timeout to RenderServer.render() #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markfinger merged 1 commit into from
Feb 27, 2017
Merged

Add timeout to RenderServer.render() #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions react/render_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ def __unicode__(self):


class RenderServer(object):
def render(self, path, props=None, to_static_markup=False, request_headers=None):
def render(
self, path, props=None, to_static_markup=False, request_headers=None,
timeout=None
):
url = conf.settings.RENDER_URL

if props is not None:
Expand All @@ -45,12 +48,17 @@ def render(self, path, props=None, to_static_markup=False, request_headers=None)
if request_headers is not None:
all_request_headers.update(request_headers)

# Add a send/receive timeout with the request if not specified
if not isinstance(timeout, (tuple, int, float)):
timeout = (5, 5)

try:
res = requests.post(
url,
data=serialized_options,
headers=all_request_headers,
params={'hash': options_hash}
params={'hash': options_hash},
timeout=timeout
)
except requests.ConnectionError:
raise RenderServerError('Could not connect to render server at {}'.format(url))
Expand Down