Skip to content

test: Cover ClassroomUser JSON marshaling#4255

Open
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:test-classroom-user-marshal
Open

test: Cover ClassroomUser JSON marshaling#4255
Haihan-Jiang wants to merge 1 commit into
google:masterfrom
Haihan-Jiang:test-classroom-user-marshal

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

Adds a standalone JSON marshal test for ClassroomUser, matching the existing Classroom tests.

ClassroomUser is exported and used inside AcceptedAssignment responses, but it did not have its own marshal coverage.

Tests:

  • script/fmt.sh
  • go test ./github -run 'TestClassroom(User)?_Marshal|TestClassroomAssignment_Marshal|TestAcceptedAssignment_Marshal|TestAssignmentGrade_Marshal'
  • script/test.sh
  • script/lint.sh

Refs #55.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label May 26, 2026
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Haihan-Jiang!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants