[spec-review] Update Safe Outputs conformance checker for recent spec changes#34589
Merged
pelikhan merged 1 commit intoMay 25, 2026
Merged
Conversation
Add TYPE-005 check for add_comment status-comment reuse extension introduced in spec version 1.21.0 (Section 7.1): - Validates target=status handling is implemented - Validates existing comment update path for status reuse - Validates fallback new-comment creation when no ID available - Validates discussion comment rejection for target=status Also updates script version header from 1.20.0 to 1.21.0. Co-authored-by: Copilot <[email protected]>
github-actions
Bot
added
automation
documentation
pelikhan
approved these changes
May 25, 2026
pelikhan
deleted the
update-safe-outputs-conformance-checker-1.21.0-cd2f55faf1ea0e32
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the Safe Outputs conformance checker to spec v1.21.0 and introduces a new TYPE-005 check that validates
add_commenthandler compliance with the status-comment reuse extension defined in Safe Outputs spec §7.1.Changes
scripts/check-safe-outputs-conformance.sh1.21.0.add_commenthandlers correctly implement the status-comment reuse behaviour mandated by Safe Outputs spec Section 7.1. This ensures handlers do not create duplicate status comments when one already exists on the target resource.Impact
scripts/(tooling only)add_comment/ status-comment reuse)Why
Safe Outputs spec v1.21.0 formalised the status-comment reuse extension in §7.1. Without this update, the conformance checker would not catch handlers that violate the new requirement, leaving non-conformant
add_commentimplementations undetected during CI validation.Testing
No production code changes — this is a script-only update. Validate by running the conformance checker locally against a workflow that uses
add_commentand confirming TYPE-005 fires as expected on a non-compliant handler.References
efc7276cd