[spec-enforcer] test: enforce specifications for console, constants, envutil#33997
Merged
pelikhan merged 1 commit intoMay 22, 2026
Conversation
Adds spec-driven tests derived from pkg/console/README.md and pkg/constants/README.md. Console additions: - ErrorPosition struct fields - FormatError, FormatErrorChain - RenderErrorBox, RenderInfoSection, RenderComposedSections - PrintBanner, ClearScreen, ClearLine - FormatPromptMessage and FormatSectionHeader added to FormatMessages table Constants additions: - CopilotBYOK constants (with SPEC_MISMATCH note for CopilotBYOKDefaultModel) - GhAwRootDir / GhAwRootDirShell - URL constants (DefaultMCPRegistryURL, PublicGitHubHost, DocsEnginesURL) - AWF constants (AWFDefaultCommand, AWFProxyLogsDir, AWFAuditDir, AWFDefaultLogLevel) - Container images (Node, Python, Alpine, MCPG, Firewall, DevMode) - GetWorkflowDir behavior (default + env override) - MaxSymlinkDepth, DefaultActivationJobRunnerImage Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
pelikhan
deleted the
spec-enforce-console-constants-envutil-2026-05-22-8a2a224dd4684418
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added comprehensive specification tests for the
pkg/consoleandpkg/constantspackages to enforce documented behavior. The console tests validate error formatting functions, error box rendering, terminal controls, and newly introduced public API functions (FormatPromptMessage,FormatSectionHeader). The constants tests ensure documented constant values remain stable across runtime configuration paths, URLs, AWF constants, container images, and default values.Change Classification
Key Changes
Impact Assessment
No downstream impact identified. These changes add test coverage to enforce existing specifications without modifying production code or public APIs.
Commits