[spec-enforcer] Enforce specifications for errorutil, syncutil, jsonutil#33527
Merged
pelikhan merged 1 commit intoMay 20, 2026
Conversation
Adds spec_test.go files derived from each package's README.md. Tests validate documented behavior, usage examples, and design notes without coupling to implementation internals. - pkg/errorutil/spec_test.go: validates IsNotFoundError, IsForbiddenError, IsGoneError contracts including the documented "forbidden character" and "gone away" anti-patterns. - pkg/syncutil/spec_test.go: validates OnceLoader[T] zero-value usability, single-loader-invocation contract, error caching with zero T, Reset semantics, and documented thread-safety guarantees. jsonutil's existing spec_test.go was reviewed and already fully covers the current README.md specification, so no changes were made to it. Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
pelikhan
deleted the
spec-enforcer/errorutil-syncutil-jsonutil-2026-05-20-9e2b5ea390e2a2cf
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added specification tests for two utility packages (
errorutilandsyncutil) to enforce behavioral contracts and improve test coverage.Changes
Tests Added (2 files)
pkg/errorutil/spec_test.goIsNotFoundError: Validates detection of 404/not-found errorsIsForbiddenError: Validates detection of 403/forbidden errorsIsGoneError: Validates detection of 410/gone errorspkg/syncutil/spec_test.goOnceLoader[T]generic typeReset()method behaviorImpact Assessment
Validation
File Manifest
Commit Reference
7f40bfff3- Enforce specifications for errorutil, syncutilMetadata