C++: Improve performance of ExprEvaluator::getFunctionValue.#411
Merged
lcartey merged 1 commit intoNov 7, 2018
Merged
Conversation
Changes the `forex` range to join on both `this` (the current `ExprEvaluator`) and `ret` (the expected function return value), so that we look at the relevant return values rather than all interesting functions.
jbj
approved these changes
Nov 6, 2018
Contributor
jbj
left a comment
jbj
left a comment
There was a problem hiding this comment.
LGTM. If it's still slow, perhaps replace forex with min/max like in the function above. See https://git.semmle.com/Semmle/code/pull/19800.
lcartey
approved these changes
Nov 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the
forexrange to join on boththis(the currentExprEvaluator) andret(the expected function return value), so that we look at the relevant return values rather than all interesting functions.