Skip to content

Stop transpiling computed property names#36542

Merged
eps1lon merged 2 commits into
facebook:mainfrom
eps1lon:sebbie/computed-properties
May 26, 2026
Merged

Stop transpiling computed property names#36542
eps1lon merged 2 commits into
facebook:mainfrom
eps1lon:sebbie/computed-properties

Conversation

@eps1lon
Copy link
Copy Markdown
Collaborator

@eps1lon eps1lon commented May 26, 2026

Support for these has landed 10 years ago in popular browsers and Node.js. Hermes also supports these.

Only affects react-server-dom-* packages in development. Google Closure Compiler still downlevels these. We're applying GCC to prod and dev nowadays so this PR just normalizes the final code between dev and prod.

For React 20, we should consider revisiting our target matrix to something more modern.

@meta-cla meta-cla Bot added the CLA Signed label May 26, 2026
@react-sizebot
Copy link
Copy Markdown

Comparing: 008a6d4...6c39adf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 614.17 kB 614.17 kB = 108.52 kB 108.52 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB = 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 680.11 kB 680.11 kB = 119.48 kB 119.48 kB
facebook-www/ReactDOM-prod.classic.js = 700.53 kB 700.53 kB = 123.05 kB 123.05 kB
facebook-www/ReactDOM-prod.modern.js = 690.84 kB 690.84 kB = 121.44 kB 121.44 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server-flight.development.js = 148.48 kB 148.07 kB = 26.69 kB 26.53 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js = 146.39 kB 145.98 kB = 26.23 kB 26.07 kB
oss-stable/react-server/cjs/react-server-flight.development.js = 146.39 kB 145.98 kB = 26.23 kB 26.07 kB

Generated by 🚫 dangerJS against 6c39adf

@eps1lon eps1lon marked this pull request as ready for review May 26, 2026 16:19
@eps1lon eps1lon requested a review from unstubbable May 26, 2026 16:20
@eps1lon eps1lon merged commit cafd63b into facebook:main May 26, 2026
240 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants