-
Notifications
You must be signed in to change notification settings - Fork 264
Extract error as const #1792
Copy link
Copy link
Closed
Labels
T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.General cleanup and restructuring of code to provide clarity, flexibility, and modularity.good first issueGood for newcomersGood for newcomers
Description
Metadata
Metadata
Assignees
Labels
T:code-hygieneGeneral cleanup and restructuring of code to provide clarity, flexibility, and modularity.General cleanup and restructuring of code to provide clarity, flexibility, and modularity.good first issueGood for newcomersGood for newcomers
Type
Fields
Give feedbackNo fields configured for issues without a type.
nitpick: I would extract
"failed to save block responses"as const.Originally posted by @tzdybal in #1782 (comment)
nitpick: Similarly to other comment, this is quite fragile - we should have this value as const somewhere or make a bit less-specific assertion.
Originally posted by @tzdybal in #1782 (comment)