use uriglob to catch all android captive portal requests#9041
Merged
Conversation
Collaborator
|
Can you please update the comment with your findings with something like edit |
Contributor
Author
|
good point. i adjusted the comment (and hopefully fixed the build error by aligning the doc comments) |
Collaborator
|
CI wants an additional space (or you can run it yourself and commit its changes, see above) |
Contributor
Author
|
sorry, first time contributing to a C/C++ project, code styles are different than what i am used to 🙈 now i ran the shell script and pushed the changes. i hope its correct now. |
Collaborator
|
Thanks ! |
Contributor
Author
|
thank you a lot for maintaining this awesome library! |
hasenradball
pushed a commit
to hasenradball/Arduino
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i observed that i get lots of
/generate_204_<uuid>requests when building the captive portal and connecting with an android phone. since #6696, the web server supports uri globs (and other features) to match requests. with the glob we can also redirect the requests with the uuid suffix.