Allow to use temporary strings in configTime#8606
Merged
Merged
Conversation
d-a-v
reviewed
Jun 23, 2022
d-a-v
reviewed
Jun 23, 2022
d-a-v
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #7056
in addition to the existing function, adds an overload accepting String
adds warning in the comment. not sure about older versions, but in ide 2.0 this will be displayed when hovering over the function call
although... there may be a confusion between F() and PSTR(). F() will be loaded into a static string, while PSTR() is const char ptr and uses the original function. at least with DNS, there's is a strlen call which will obviously fail