Use of Uri in webserver breaks current implementations

[TD-er]

Basic Infos

• This issue complies with the issue POLICY doc.
• I have read the documentation at readthedocs and the issue is not addressed there.
• I have tested that the issue is present in current master branch (aka latest git).
• I have searched the issue tracker for a similar issue.
• If there is a stack dump, I have decoded it.
• I have filled out all fields below.

Platform

• Breaking commit: 4eca62c

Problem Description

When calling the WebServer.on(...) function with a flash string, the compiler refuses to build.

Example error:

C:/GitHub/TD-er/ESPEasy/src/WebServer.ino:603:6: error: no matching function for call to 'esp8266webserver::ESP8266WebServerTemplate<WiFiServer>::on(const __FlashStringHelper*, HTTPMethod, WebServerInit()::__lambda4)'

Simple work-around is to replace all calls like this with a String() wrapper around the flash string.

I guess the best fix would be to add a constructor for Uri with const __FlashStringHelper* as parameter.

N.B. some of the derived classes use explicit in the constructor definition, but Uri not. Is this intentional?

[devyte]

I guess we forgot the forwarder method on(const String & uri,...) that forwards with on(Uri(uri),...).
Broken in #6696.

Edit: the base Uri already has the functionality needed. It's just the forwarder that's missing.

[devyte]

@Bmooij is there any chance you could help with this? The fix should be easy.

[devyte]

N.B. some of the derived classes use explicit in the constructor definition, but Uri not. Is this intentional?

Yes. The explicit in the derived classes is meant to force the user to use them and not have an automatic conversion into them, while the lack of it in the base class is meant for exactly that purpose. Which is why the example works.

[devyte]

@TD-er does #7105 fix your issue?

[TD-er]

@TD-er does #7105 fix your issue?

Yes, it does :)