Fix Jessie syntax parsing edge cases#39
Open
davejcameron wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A few valid Jessie/JavaScript syntax forms currently fail to parse:
Decimal literals can consume the member-access dot,
case/defaultboundary detection can reject object properties inside switch case bodies, and async method shorthand is parsed as an async call before the method parser can see the body.Fix
Parse decimal numbers in phases so member access remains available after a decimal literal.
Respect property-name context when reserving
caseanddefaultas switch case-body boundaries.Let the async parser preserve plain async method names for the existing method-shorthand parser, then wrap the method value in an
asyncAST node.Validation
node --import ./test/https-loader.js test/feature/async-class.jspnpm testpasses except existingunicode: many non-ASCII identifiers (scaling): Maximum call stack size exceeded