Enumerable Select skip iterator alloction when empty IList#128556
Closed
snakefoot wants to merge 1 commit into
Closed
Enumerable Select skip iterator alloction when empty IList#128556snakefoot wants to merge 1 commit into
snakefoot wants to merge 1 commit into
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Optimizes Enumerable.Select by adding an early-exit path for empty list-like sources and removing a redundant empty-array check.
Changes:
- Adds an early return for
IList<TSource>whenCount == 0. - Removes the prior
TSource[]-specificLength == 0early return (now covered by theIList<TSource>branch).
Comment on lines
45
to
+50
| if (source is IList<TSource> ilist) | ||
| { | ||
| if (ilist.Count == 0) | ||
| { | ||
| return []; | ||
| } |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-linq |
This was referenced May 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.