test: add postcleanup mode#2417
Open
yaroslavborbat wants to merge 1 commit into
Open
Conversation
Signed-off-by: Yaroslav Borbat <[email protected]>
f09d14b to
65ccfa1
Compare
hardcoretime
requested changes
May 29, 2026
|
|
||
| // PostCleanupEnv defines an environment variable used to explicitly request the deletion of created/used resources. | ||
| // Valid values: "yes", "no", or "" (default = yes). | ||
| // Valid values: "always", "never", "no-failure", or "" (default = always). |
Contributor
There was a problem hiding this comment.
Suggested change
| // Valid values: "always", "never", "no-failure", or "" (default = always). | |
| // Valid values: "always", "never", "no-on-failure", or "" (default = always). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace boolean
IsCleanupNeededflag withPostCleanupModeenum in e2e test config.New values for
POST_CLEANUPenv:always(default) — always clean up resources after testsnever— never clean up (useful for debugging)no-failure— skip cleanup only when the test suite fails, preserving resources on failure for investigation (cleanup runs on success)Why do we need it, and what problem does it solve?
The old boolean flag (
yes/no) didn't allow keeping resources when tests fail while still cleaning up on success. The newno-failuremode fills this gap, making it easier to debug failing e2e tests without manually toggling cleanup.What is the expected result?
POST_CLEANUP=no-failurebefore running e2e testsChecklist
Changelog entries