Skip to content

fix(storybook): disabling shortcuts to avoid keystrokes being eaten#7557

Open
tbaxter-coveo wants to merge 3 commits into
mainfrom
bugfix/DOC-19210-storybook-keystroke
Open

fix(storybook): disabling shortcuts to avoid keystrokes being eaten#7557
tbaxter-coveo wants to merge 3 commits into
mainfrom
bugfix/DOC-19210-storybook-keystroke

Conversation

@tbaxter-coveo
Copy link
Copy Markdown
Contributor

JIRA

https://coveord.atlassian.net/browse/DOC-19210

Purpose

This disables Storybook shortcuts to avoid Storybook intercepting keystrokes to toggle on/off certain tools.

In addition, this adds in a missing "prod" script for atomic. According to its README:

Building and serving Storybook locally

To build the Storybook site for production and serve it locally:

# Build the Atomic library and Storybook
pnpm turbo build --filter=@coveo/atomic

# Serve the production Storybook build
pnpm turbo run prod --filter=@coveo/atomic

The production Storybook site will be available at http://localhost:4400.

[!NOTE]
The build command includes the build:storybook step, which outputs the static site to dist-storybook/.
This is the same output that gets deployed to the CDN. Use this to verify that components render correctly in a production build.

There was no prod command in Atomic

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: 2249a8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svcsnykcoveo
Copy link
Copy Markdown

svcsnykcoveo commented May 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Atomic’s Storybook setup to prevent Storybook keyboard shortcuts from intercepting user keystrokes, and adds a missing production-serving script for the prebuilt Storybook output.

Changes:

  • Disable Storybook manager keyboard shortcuts via addons.setConfig({ enableShortcuts: false }).
  • Add an Atomic prod script to serve dist-storybook/ locally on port 4400.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/atomic/package.json Adds a prod script to serve the static Storybook build from dist-storybook/.
packages/atomic/.storybook/manager.tsx Disables Storybook manager shortcuts to avoid keystrokes being intercepted.

Comment thread packages/atomic/package.json
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 6, 2026

@coveo/atomic

npm i https://pkg.pr.new/@coveo/atomic@7557

@coveo/atomic-hosted-page

npm i https://pkg.pr.new/@coveo/atomic-hosted-page@7557

@coveo/atomic-legacy

npm i https://pkg.pr.new/@coveo/atomic-legacy@7557

@coveo/atomic-react

npm i https://pkg.pr.new/@coveo/atomic-react@7557

@coveo/auth

npm i https://pkg.pr.new/@coveo/auth@7557

@coveo/bueno

npm i https://pkg.pr.new/@coveo/bueno@7557

@coveo/create-atomic

npm i https://pkg.pr.new/@coveo/create-atomic@7557

@coveo/create-atomic-component

npm i https://pkg.pr.new/@coveo/create-atomic-component@7557

@coveo/create-atomic-component-project

npm i https://pkg.pr.new/@coveo/create-atomic-component-project@7557

@coveo/create-atomic-result-component

npm i https://pkg.pr.new/@coveo/create-atomic-result-component@7557

@coveo/create-atomic-rollup-plugin

npm i https://pkg.pr.new/@coveo/create-atomic-rollup-plugin@7557

@coveo/headless

npm i https://pkg.pr.new/@coveo/headless@7557

@coveo/headless-react

npm i https://pkg.pr.new/@coveo/headless-react@7557

@coveo/shopify

npm i https://pkg.pr.new/@coveo/shopify@7557

commit: 2249a8f

@chromatic-com
Copy link
Copy Markdown

chromatic-com Bot commented May 6, 2026

Tip

All tests passed and all changes approved!

🟢 UI Tests: 367 tests unchanged
🟢 UI Review: 367 stories published -- no changes
Storybook icon Storybook Publish: 367 stories published

@tbaxter-coveo tbaxter-coveo added this pull request to the merge queue May 25, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants