fix(storybook): disabling shortcuts to avoid keystrokes being eaten#7557
fix(storybook): disabling shortcuts to avoid keystrokes being eaten#7557tbaxter-coveo wants to merge 3 commits into
Conversation
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR updates Atomic’s Storybook setup to prevent Storybook keyboard shortcuts from intercepting user keystrokes, and adds a missing production-serving script for the prebuilt Storybook output.
Changes:
- Disable Storybook manager keyboard shortcuts via
addons.setConfig({ enableShortcuts: false }). - Add an Atomic
prodscript to servedist-storybook/locally on port4400.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/atomic/package.json | Adds a prod script to serve the static Storybook build from dist-storybook/. |
| packages/atomic/.storybook/manager.tsx | Disables Storybook manager shortcuts to avoid keystrokes being intercepted. |
@coveo/atomic
@coveo/atomic-hosted-page
@coveo/atomic-legacy
@coveo/atomic-react
@coveo/auth
@coveo/bueno
@coveo/create-atomic
@coveo/create-atomic-component
@coveo/create-atomic-component-project
@coveo/create-atomic-result-component
@coveo/create-atomic-rollup-plugin
@coveo/headless
@coveo/headless-react
@coveo/shopify
commit: |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 367 tests unchanged |
JIRA
https://coveord.atlassian.net/browse/DOC-19210
Purpose
This disables Storybook shortcuts to avoid Storybook intercepting keystrokes to toggle on/off certain tools.
In addition, this adds in a missing "prod" script for atomic. According to its README:
There was no
prodcommand in Atomic