Conversation
dmbrooke
commented
Oct 16, 2023
dmbrooke
requested review from
a team,
louis-bompart,
olamothe and
y-lakhdar
and removed request for
a team
olamothe
approved these changes
Oct 24, 2023
louis-bompart
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-2804
Very similar to my changes to the other two SDKs. Took a bit longer to figure out the best way to retrieve the version from pom.xml, but eventually decided to go with a simple method. Added
maven-modelto the dependencies such that we can easily readpom.xmland get the version property that way.