Skip to content

Update Kaniko#7

Merged
johnstcn merged 367 commits into
mainfrom
merge
May 20, 2024
Merged

Update Kaniko#7
johnstcn merged 367 commits into
mainfrom
merge

Conversation

@kylecarbs
Copy link
Copy Markdown
Member

@kylecarbs kylecarbs commented May 6, 2024 •
edited
Loading

See actual changes from upstream: GoogleContainerTools/kaniko@main...coder:kaniko:merge

dependabot Bot and others added 30 commits August 13, 2023 20:47
@dependabot
chore(deps): bump golang from 1.20 to 1.21 in /deploy (GoogleContaine…
232c77d 
…rTools#2682)

Bumps golang from 1.20 to 1.21.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump google.golang.org/api from 0.134.0 to 0.136.0 (Goog…
dd8315a 
…leContainerTools#2681)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.134.0 to 0.136.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.134.0...v0.136.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (GoogleContaine…
92afe09 
…rTools#2680)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.31 to 1.18.33.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.31...config/v1.18.33)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager (Go…
176f5b4 
…ogleContainerTools#2679)

Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.75 to 1.11.77.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.75...feature/s3/manager/v1.11.77)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@cmdjulian
Added skip-push-permission flag (GoogleContainerTools#2657)
cefe99b 
Added skip-push-permission flag to conditionally disable push permission check on build start to accommodate for slow network policies
@aaron-prindle
chore(release): release v1.14.0 (GoogleContainerTools#2683)
2ca710a
@JeromeJu
Change condition for the behavior when --no-push=true without --desti…
6ee84f1 
…nations (GoogleContainerTools#2676)

This commit changes the condition check for the behavior when no-push is
set to true while destinations are needed. Prior this change, users would
have to set destinations even when noPush option is set to true. More
specifically, a workaround for tar files to be generated when --no-push is
true and destinations is empty is provided where a dummy destination would be
set.
@aaron-prindle
docs: add more information regarding --use-new-run (GoogleContainerTo…
8a0af16 
…ols#2687)
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager (Go…
e795c1c 
…ogleContainerTools#2690)

Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.77 to 1.11.79.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.77...feature/s3/manager/v1.11.79)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump cloud.google.com/go/storage from 1.31.0 to 1.32.0 (G…
3f99717 
…oogleContainerTools#2692)

Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.31.0 to 1.32.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.31.0...pubsub/v1.32.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@aaron-prindle
docs: fix --use-new-run typo (GoogleContainerTools#2698)
d02945f
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2 from 1.20.3 to 1.21.0 (G…
dba9483 
…oogleContainerTools#2703)

Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.20.3 to 1.21.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.20.3...v1.21.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump google.golang.org/api from 0.136.0 to 0.138.0 (Goog…
e32f99c 
…leContainerTools#2704)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.136.0 to 0.138.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.136.0...v0.138.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/s3 (GoogleCont…
3e9939d 
…ainerTools#2706)

Bumps [github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2) from 1.38.4 to 1.38.5.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.38.4...service/s3/v1.38.5)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/s3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager (Go…
2c5a6d6 
…ogleContainerTools#2702)

Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.79 to 1.11.81.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.79...feature/s3/manager/v1.11.81)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@loganprice
fix: ensure layer media type matches image media type if oci image (G…
e9787f8 
…oogleContainerTools#2700)

test: add to ensure media type being saved
@JeromeJu
chore(release): release v1.15.0 (GoogleContainerTools#2711)
237778c
@gadiego92
Avoid returning the UID when resolving the GIDs. (GoogleContainerTool…
2b6b594 
…s#2689)

* Fix GetUIDAndGIDFromString test.

* Avoid returning by default the UID when resolving the GIDs.
@geekvest
fix function name on comment (GoogleContainerTools#2707)
5df0343 
Signed-off-by: geekvest <[email protected]>
@testwill
chore: unnecessary use of fmt.Sprintf (GoogleContainerTools#2717)
382cf3a 
Signed-off-by: guoguangwu <[email protected]>
@dependabot
chore(deps): bump golang.org/x/sys from 0.11.0 to 0.12.0 (GoogleConta…
517b69d 
…inerTools#2722)

Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.11.0 to 0.12.0.
- [Commits](golang/sys@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/config (GoogleContaine…
16df510 
…rTools#2724)

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.37 to 1.18.38.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.18.37...config/v1.18.38)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump docker/setup-buildx-action from 2.9.1 to 2.10.0 (Go…
eef17f6 
…ogleContainerTools#2726)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.9.1 to 2.10.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@4c0219f...885d146)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump sigstore/cosign-installer from 3.1.1 to 3.1.2 (Goog…
621802f 
…leContainerTools#2727)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@6e04d22...11086d2)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/containerd/containerd from 1.7.3 to 1.7.5 (
665d0be 
GoogleContainerTools#2723)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.3 to 1.7.5.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](containerd/containerd@v1.7.3...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump golang.org/x/net from 0.14.0 to 0.15.0 (GoogleConta…
7ec5cbe 
…inerTools#2734)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.14.0 to 0.15.0.
- [Commits](golang/net@v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/aws/aws-sdk-go-v2/feature/s3/manager (Go…
1b40e14 
…ogleContainerTools#2733)

Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.81 to 1.11.83.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.81...feature/s3/manager/v1.11.83)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump golang.org/x/oauth2 from 0.11.0 to 0.12.0 (GoogleCo…
8d7d925 
…ntainerTools#2732)

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.11.0 to 0.12.0.
- [Commits](golang/oauth2@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump docker/build-push-action from 4.1.1 to 4.2.1 (Googl…
272e598 
…eContainerTools#2739)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 4.1.1 to 4.2.1.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@2eb1c19...0a97817)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump cloud.google.com/go/storage from 1.32.0 to 1.33.0 (G…
0097615 
…oogleContainerTools#2740)

Bumps [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) from 1.32.0 to 1.33.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.32.0...pubsub/v1.33.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot Bot and others added 8 commits April 19, 2024 10:33
@dependabot
chore(deps): bump github.com/Azure/azure-sdk-for-go/sdk/storage/azblob (
4a516db 
GoogleContainerTools#3114)

Bumps [github.com/Azure/azure-sdk-for-go/sdk/storage/azblob](https://github.com/Azure/azure-sdk-for-go) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases)
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md)
- [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.3.1...sdk/storage/azblob/v1.3.2)

---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump golang.org/x/net from 0.22.0 to 0.24.0 (GoogleConta…
5c56bdf 
…inerTools#3113)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.22.0 to 0.24.0.
- [Commits](golang/net@v0.22.0...v0.24.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@viviengaetan
fix(doc): wiki url (GoogleContainerTools#3117)
d070187
@mschneider82
fix: integration: fail on error when build with docker (GoogleContain…
d251b81 
…erTools#3131)
@dependabot
chore(deps): bump google.golang.org/api from 0.172.0 to 0.175.0 (Goog…
072213b 
…leContainerTools#3128)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.172.0 to 0.175.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.172.0...v0.175.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/google/slowjam from 1.1.0 to 1.1.1 (Goog…
87e646a 
…leContainerTools#3129)

Bumps [github.com/google/slowjam](https://github.com/google/slowjam) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/google/slowjam/releases)
- [Commits](google/slowjam@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: github.com/google/slowjam
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mschneider82
feat: Added --chmod for ADD and COPY command. Fixes GoogleContainerTo…
a9062b9 
…ols#2850 (GoogleContainerTools#3119)
@aaron-prindle
chore: bump cred helper libraries (GoogleContainerTools#3133)
28e4e29
@kylecarbs kylecarbs self-assigned this May 6, 2024
@kylecarbs kylecarbs force-pushed the merge branch 4 times, most recently from b066131 to 778b4c5 Compare May 6, 2024 20:50
@kylecarbs kylecarbs mentioned this pull request May 6, 2024
Closed
@kylecarbs kylecarbs force-pushed the merge branch 2 times, most recently from 605997a to 8b5f860 Compare May 6, 2024 20:55
This was referenced May 15, 2024
Closed
Merged
@johnstcn johnstcn requested review from johnstcn and mafredri May 17, 2024 15:38
@johnstcn johnstcn requested a review from mtojek May 20, 2024 08:20
mtojek
mtojek approved these changes May 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledge failing tests

@johnstcn
Copy link
Copy Markdown
Member

johnstcn commented May 20, 2024

I'm going to go ahead and merge this:

  • The unit tests failing are due to 6431577 -- when run with root privilege, they succeed.

  • The failing integration tests are also failing due to 6431577 -- see the output below:

2024-05-17T16:07:01.4793152Z             �[36mINFO�[0m[0000] Running: [/bin/sh -c printf "%s\n"       "0 0 /myapp/"       "123 123 /myapp/somedir"       "321 321 /myapp/somedir/somefile"       > /tmp/expected  && stat -c "%u %g %n"       /myapp/       /myapp/somedir       /myapp/somedir/somefile       > /tmp/got  && diff -u /tmp/got /tmp/expected] 
2024-05-17T16:07:01.4794477Z             --- /tmp/got
2024-05-17T16:07:01.4794984Z             +++ /tmp/expected
2024-05-17T16:07:01.4795458Z             @@ -1,3 +1,3 @@
2024-05-17T16:07:01.4795828Z              0 0 /myapp/
2024-05-17T16:07:01.4796338Z             -0 0 /myapp/somedir
2024-05-17T16:07:01.4796867Z             -0 0 /myapp/somedir/somefile
2024-05-17T16:07:01.4797312Z             +123 123 /myapp/somedir
2024-05-17T16:07:01.4797880Z             +321 321 /myapp/somedir/somefile
2024-05-17T16:07:01.4799232Z             error building image: error building stage: failed to execute command: waiting for process to exit: exit status 1

@johnstcn johnstcn merged commit ba712f2 into main May 20, 2024
johnstcn added a commit to coder/envbuilder that referenced this pull request May 20, 2024
@johnstcn
point to main branch after merging coder/kaniko#7
fb8cd92
@mafredri
Copy link
Copy Markdown
Member

mafredri commented May 20, 2024

@johnstcn can't we fix the failing tests since we know the cause and it's as expected?

@mafredri mafredri deleted the merge branch September 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtojek mtojek mtojek approved these changes

@mafredri mafredri Awaiting requested review from mafredri

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@kylecarbs kylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.