refactor(ui): Make FactorOne sub-cards prop-driven#8656
Draft
alexcarpenter wants to merge 3 commits into
Draft
Conversation
…bility PasswordCard, CodeForm, and AlternativeChannelCodeForm no longer read context hooks (useCoreSignIn, useRouter, useHandleFirstFactorResult). Parent container provides callbacks and data as props. Adds snapshot tests for both card types. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0cd0fcf The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
…s prop-driven Container/view split for FactorOne: SignInFactorOne becomes a pure container (context + state), SignInFactorOneView is a pure-props component rendering the correct sub-card. EmailLinkCard, Passkey, and EnterpriseConnections are now prop-driven. Adds 9 snapshot tests for the view component covering all factor strategies. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useCoreSignIn,useRouter,useHandleFirstFactorResult). The parentSignInFactorOnecontainer provides callbacks and data as props.useFetchstays in CodeForm but callsprops.onPrepare(factor)instead ofsignIn.prepareFirstFactor(factor)directly.factorKey()toutils.ts(was inline in SignInFactorOne).renderForSnapshotfrom PR refactor(ui): Shared sign-in hooks + snapshot test helper #8652.Stacked on #8652.
Test plan
🤖 Generated with Claude Code