TA-4733: Exclude symlinks in folder export#295
Merged
Laberion Ajvazi (LaberionAjvazi) merged 2 commits intoDec 16, 2025
Conversation
|
Meris Nici (promeris)
approved these changes
Dec 16, 2025
Jeta (jetakasabaqi)
approved these changes
Dec 16, 2025
Buqeta (Buqeta)
approved these changes
Dec 16, 2025
Zgjim Haziri (ZgjimHaziri)
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Used the lstat function to check if the source directory or any of its nested files are symbolic links.
isFileandisFolderof thelstatsresult will return false if the path is a symLink.Other: Removed unused
copyDirectoryToCurrentLocationmethod.Relevant links
Checklist
Note
Exclude symlinks when zipping directories (error on symlink source) and add tests to validate behavior.
src/core/utils/file-service.ts):zipDirectoryInBatchExportFormat:FatalErrorifsourceDiris a symbolic link.fs.lstatSyncto detect and skip symlinked files/folders.copyDirectoryToCurrentLocationmethod.tests/core/utils/file.service.spec.ts):Written by Cursor Bugbot for commit 04b7f98. This will update automatically on new commits. Configure here.