Add ability to pass additional request headers to render server#2
Merged
Conversation
| # An optional object which will be used instead of the default renderer | ||
| renderer=None, | ||
|
|
||
| # An optional dictionary of request header information (such as `Accept-language`) |
There was a problem hiding this comment.
nitpick: Accept-Language has the L capitalized too
There was a problem hiding this comment.
This could be a good spot to put in a sample dictionary (like props does above).
BenAtEventbrite
force-pushed
the
request-headers
branch
from
196c0c9 to
2e2640e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eventbrite needs the ability to pass language information from the Django layer to the React render server. This PR enables being able to pass any request headers in the
POSTto the server.