Task/sdev 5403 hrd kb category#116
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands HRD (homologous recombination deficiency) support by (a) adding an integration test that exercises HRD signature annotation and (b) tightening the report-content JSON schema to only accept known HRD kbCategory values.
Changes:
- Added GraphKB-backed annotation test coverage for the HRD “strong signature” category (and a skipped test placeholder for “moderate”).
- Restricted
hrd.kbCategoryin the content JSON schema to an explicit enum of the two supported HRD categories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_ipr/test_annotate.py | Adds HRD signature annotation test(s) using HRD_MAPPING. |
| pori_python/ipr/content.spec.json | Constrains hrd.kbCategory to the supported HRD category strings via enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Had to change enum into examples so other, non hr deficient categories, can be passed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #116 +/- ##
===========================================
- Coverage 84.12% 83.93% -0.20%
===========================================
Files 18 18
Lines 2608 2608
===========================================
- Hits 2194 2189 -5
- Misses 414 419 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.