Skip to content

Task/sdev 5403 hrd kb category#116

Open
mathieulemieux wants to merge 3 commits into
developfrom
task/SDEV-5403-hrd-kbCategory
Open

Task/sdev 5403 hrd kb category#116
mathieulemieux wants to merge 3 commits into
developfrom
task/SDEV-5403-hrd-kbCategory

Conversation

@mathieulemieux
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands HRD (homologous recombination deficiency) support by (a) adding an integration test that exercises HRD signature annotation and (b) tightening the report-content JSON schema to only accept known HRD kbCategory values.

Changes:

  • Added GraphKB-backed annotation test coverage for the HRD “strong signature” category (and a skipped test placeholder for “moderate”).
  • Restricted hrd.kbCategory in the content JSON schema to an explicit enum of the two supported HRD categories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tests/test_ipr/test_annotate.py Adds HRD signature annotation test(s) using HRD_MAPPING.
pori_python/ipr/content.spec.json Constrains hrd.kbCategory to the supported HRD category strings via enum.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pori_python/ipr/content.spec.json
dustinbleile
dustinbleile previously approved these changes May 26, 2026
@mathieulemieux
Copy link
Copy Markdown
Member Author

Had to change enum into examples so other, non hr deficient categories, can be passed.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.93%. Comparing base (4be81db) to head (bb9c6ae).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
- Coverage    84.12%   83.93%   -0.20%     
===========================================
  Files           18       18              
  Lines         2608     2608              
===========================================
- Hits          2194     2189       -5     
- Misses         414      419       +5     
Flag Coverage Δ
unittests 83.93% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants