fix(docs): replace Math.random() with crypto.randomUUID() for SIWE nonces#1555
Open
faisalnugroho wants to merge 1 commit into
Open
fix(docs): replace Math.random() with crypto.randomUUID() for SIWE nonces#1555faisalnugroho wants to merge 1 commit into
faisalnugroho wants to merge 1 commit into
Conversation
…nces Math.random() is not cryptographically secure and should never be used for SIWE nonces. A predictable nonce can be exploited for replay attacks. Replaced all instances with crypto.randomUUID() which is: - Cryptographically secure (Web Crypto API) - Available in all modern browsers and Node.js 19+ - Consistent with the authenticate-users guide Closes base#1477
Collaborator
🟡 Heimdall Review Status
|
Author
|
Hi! Following up on this security fix PR. This PR replaces Math.random() with crypto.randomUUID() for SIWE nonce generation. Math.random() is not cryptographically secure and could allow nonce prediction attacks. All CI checks pass (StepSecurity ✅). Would love to get your review when you have a moment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all instances of
Math.random()used for SIWE nonce generation withcrypto.randomUUID().Files fixed:
sign-in-with-base-button.mdx— nonce generationsign-and-verify-typed-data.mdx— nonce generationwagmi/setup.mdx— client nonce generationWhy
Math.random()is not cryptographically secure. Predictable nonces can be exploited for replay attacks.crypto.randomUUID()is:authenticate-usersguideTest Plan
Closes #1477