fix(candlestick): apply canvas-level clipPath in normal rendering mode#21628
Open
wplong11 wants to merge 1 commit into
Open
fix(candlestick): apply canvas-level clipPath in normal rendering mode#21628wplong11 wants to merge 1 commit into
wplong11 wants to merge 1 commit into
Conversation
## 작업 배경 - CandlestickView normal mode에서 clip:true 설정 시에도 canvas-level clipPath가 적용되지 않아 multi-grid 레이아웃에서 candlestick wick이 인접 grid 영역으로 침범하는 버그 ## 작업 내용 - _renderNormal()에서 clip:true일 때 group.setClipPath() 적용 (LineView와 동일한 방식) - render()에서 무조건 호출하던 group.removeClipPath() 제거 — _renderNormal과 _renderLarge 각각에서 clip 상태에 따라 처리 - 기존 per-item isNormalBoxClipped 검사는 최적화로 유지 (전체 영역 밖 item skip) Fixes apache#21627
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
group.setClipPath()in candlestick normal rendering mode whenclip: true, consistent with howLineViewhandles clipping.CandlestickView.render()unconditionally removed the clip path and relied solely on a per-itemisNormalBoxClipped()visibility check, which allowed partially-visible candlestick wicks to render outside the grid boundary.isNormalBoxClippedcheck is kept as an optimization to skip items entirely outside the clip area.Fixes #21627
Changes
src/chart/candlestick/CandlestickView.tsgroup.removeClipPath()call fromrender()(previously line 52) — clip path lifecycle is now managed by_renderNormaland_renderLargeindividually._renderNormal(): whenclip: true, appliesgroup.setClipPath(createClipPath(coord, false, seriesModel)); otherwise callsgroup.removeClipPath().Before / After
Live reproducer: https://wplong11.github.io/echarts-candlestick-clip-bug/
Test plan
'none'and'empty'— both should show no bleedsetClipPath)