Skip to content

chore(x): add doc lint#95

Merged
notfilippo merged 2 commits into
apache:mainfrom
notfilippo:x-add-doc-lint
Feb 14, 2026
Merged

chore(x): add doc lint#95
notfilippo merged 2 commits into
apache:mainfrom
notfilippo:x-add-doc-lint

Conversation

@notfilippo
Copy link
Copy Markdown
Member

@notfilippo notfilippo commented Feb 14, 2026

Add cargo doc that treats warnings as errors to the linting suite of the xtast.

Comment thread xtask/src/main.rs Outdated
"datasketches",
"--all-features",
]);
if !fix {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no real --fix for cargo doc :( Not sure what's the best solution here.

Copy link
Copy Markdown
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good.

But since it cannot be fixed anyway, I'd prefer run the same warning as error when executing linters.

This is because during the development, developers may often run only cargo x lint --fix, so error in the first place helps.

@notfilippo notfilippo merged commit 761491e into apache:main Feb 14, 2026
9 checks passed
@notfilippo notfilippo deleted the x-add-doc-lint branch April 13, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants