Updated spotbugs and fixed all the warnings.#182
Merged
Conversation
jmalkin
approved these changes
May 12, 2024
Contributor
jmalkin
left a comment
jmalkin
left a comment
There was a problem hiding this comment.
Workflow changes are always so frustrating. Hours of work and you feel like you have so little to show for it at the end!
| on: | ||
| pull_request: | ||
| push: | ||
| # branches: [ master ] |
Contributor
There was a problem hiding this comment.
Dunno if you wanted this commented out? Certainly not a blocker to the PR either way, but ideally either uncomment or remove the line.
Member
Author
There was a problem hiding this comment.
Yeah, it needs to be uncommented before it goes into release branch.
| workflow_dispatch: | ||
|
|
||
| env: | ||
| MAVEN_OPTS: -Xmx4g -Xms1g |
Member
Author
There was a problem hiding this comment.
Oh jees, that has been there for a long time, I don't remember why I made it 4g at the time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for a bug fix release 2.2.1. However, because the new version of SpotBugs found new warnings, I wanted to fix those issues as well. I also upgraded Maven plugins in POM to their more recent versions.