Skip to content

GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs#35811

Merged
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-14790
May 30, 2023
Merged

GH-14790: [Dev] Avoid extra comment with Closes issue id on PRs#35811
raulcd merged 2 commits into
apache:mainfrom
raulcd:GH-14790

Conversation

@raulcd
Copy link
Copy Markdown
Member

@raulcd raulcd commented May 29, 2023 •
edited
Loading

Rationale for this change

We are duplicating the Closes issue_id comment on PRs adding it to both the PR body and a comment. There was some discussion to remove it from the comment.

What changes are included in this PR?

Remove adding extra comment to PR and check whether Closes XXX was already added on the body instead of checking comment.

Are these changes tested?

Yes, I have tested on my fork, see this PR: raulcd#79

Are there any user-facing changes?

No

@raulcd raulcd requested review from assignUser and kou as code owners May 29, 2023 09:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2023

@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label May 29, 2023
kou
kou approved these changes May 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread .github/workflows/dev_pr/link.js Outdated
@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels May 29, 2023
raulcd
raulcd commented May 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels May 30, 2023
@raulcd raulcd added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels May 30, 2023
@raulcd raulcd merged commit 431785f into apache:main May 30, 2023
@ursabot
Copy link
Copy Markdown

ursabot commented May 31, 2023

Benchmark runs are scheduled for baseline = 1951a1a and contender = 431785f. 431785f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.15% ⬆️0.62%] test-mac-arm
[Failed ⬇️0.0% ⬆️11.89%] ursa-i9-9960x
[Failed ⬇️0.54% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 431785f3 ec2-t3-xlarge-us-east-2
[Failed] 431785f3 test-mac-arm
[Failed] 431785f3 ursa-i9-9960x
[Finished] 431785f3 ursa-thinkcentre-m75q
[Finished] 1951a1ae ec2-t3-xlarge-us-east-2
[Finished] 1951a1ae test-mac-arm
[Finished] 1951a1ae ursa-i9-9960x
[Failed] 1951a1ae ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@assignUser assignUser assignUser approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Dev] Improve the link script to avoid extra comment

4 participants

@raulcd @ursabot @kou @assignUser