chore(types): pin AdCP spec to 3.1.0-rc.6#910
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
LGTM. Clean spec pin from 3.1.0-rc.4 to 3.1.0-rc.6 — additive enum values, optional new fields, no shape changes on the wire.
Things I checked
src/adcp/ADCP_VERSION(3.1.0-rc.4 → 3.1.0-rc.6) matches the newschemas/cache/3.1.0-rc.6/directory.SCHEMA_DELTAS.mdaccurately enumerates the diff —EventType +{content_view,follow,watch_milestone}, newEventSurfaceclass,Event.surface,EventCustomData.{progress_percent,progress_seconds},EventSource.{action_source,surface}.- Every new field on existing models is
| None(verifiedcore/event.py:46-49,core/event_custom_data.py:60-75).EventSurface.categoryis the one required field, andEventSurfaceitself is always optional. Non-breaking —chore(types):is the right prefix, no!needed. - Codegen timestamps (
2026-06-01T00:32:59+00:00) and# generated by datamodel-codegenheaders consistent across regenerated files — not hand-edited. - Only three hand-touched files outside
generated_poc/andschemas/cache/:SCHEMA_DELTAS.md,ADCP_VERSION,_generated.py.aliases.py,_ergonomic.py,_forward_compat.pyuntouched, as expected for an additive regen. _generated.pyCategoryre-pointing (governance.sync_plans_response.Category→core.event_surface.Category) is internal-only churn —Categoryis not exported fromsrc/adcp/types/__init__.py.__all__, andgrepfinds no non-allowlisted importer ofCategoryfrom_generated. The only re-point in the diff.code-reviewer: clean, one follow-up.
Follow-ups (non-blocking — file as an issue)
EventSurfaceis in_generated.__all__but not insrc/adcp/types/__init__.py.__all__. Buyers will seeEvent.surface: EventSurface | Noneon the public model but cannotfrom adcp.types import EventSurfaceto construct one. Same gap for the newCategoryenum incore/event_surface.py:14-25if adopters want to setsurface.categoryfrom a typed value rather than a string. Codegen doesn't edit__init__.py, which is why this slipped — add to the post-regen fix script or to the public re-export block.
The chore-vs-feat call is interesting given that adopters do get new surface fields, but the regeneration is mechanical and the prefix matches how prior rc.X pins have shipped.
LGTM. Follow-ups noted below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the bundled AdCP spec version to 3.1.0-rc.6 and adds the matching schema cache generated from the published bundle.
Regenerates Pydantic types and exports so the rc.6 event tracking surface is available, including EventSurface, event surface/action_source fields, content progress fields, and follow/content_view/watch_milestone event types.
Updates SCHEMA_DELTAS.md to summarize the generated field changes.
Validated with make regenerate-schemas, pre-commit hooks during commit, and focused pytest schema/version/public API suites.