✨ use cluster stack content hash instead of git commit hash#122
Merged
Conversation
Member
Author
❯ ./bin/csctl create tests/cluster-stacks/docker/ferrol -m hash -o .test-releases
path "tests/cluster-stacks/docker/ferrol": cluster stack hash: "u2vqtxcihozkxc1ytku5qfwy0ao4foxzgwbgnracc"
Creating output in .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc
.tmp/cluster-addon/Chart.yaml updating version from v0 to v0-sha.u2vqtxc
.tmp/cluster-class/Chart.yaml updating version from v0 to v0-sha.u2vqtxc
No provider specific configuration in csctl.yaml. No need to call a plugin for provider "docker"
Created .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc
☸️ kind-cso 📁 csctl on ani/issues/121 [$?] via v1.21.6
❯ ls .test-releases/docker-ferrol-1-27-v0-sha-u2vqtxc
cluster-addon-values.yaml docker-ferrol-1-27-cluster-addon-v0-sha.u2vqtxc.tgz docker-ferrol-1-27-cluster-class-v0-sha.u2vqtxc.tgz hashes.json metadata.yamltest results |
janiskemper
approved these changes
May 16, 2024
Member
janiskemper
left a comment
janiskemper
left a comment
There was a problem hiding this comment.
@jschoone can open further issues if he needs it
Member
|
@aniruddha2000 can you rebase? And then let's merge this to not get another conflict |
aniruddha2000
force-pushed
the
ani/issues/121
branch
from
41f1f67 to
68bfc42
Compare
Signed-off-by: Aniruddha Basak <[email protected]>
aniruddha2000
force-pushed
the
ani/issues/121
branch
from
f62d1d2 to
a3893ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #121
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: